OVS/GRE: bug fixes by weizhouapache · Pull Request #5446 · apache/cloudstack

weizhouapache · 2021-09-13T18:21:54Z

Description

This PR fixes some issues with OVS/GRE
Issues with isolated networks/vpcs: #2886 #2996 #3802
Issues with shared networks: #2863 #2885

To test this PR, we need to create a zone with isolation method 'GRE' instead of default 'VLAN'.

Test results
(1) smoke test test/integration/smoke/test_privategw_acl_ovs_gre.py passed on kvm and xenserver
(2) component test test/integration/component/test_vpc_distributed_routing_offering.py passed on xenserver.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2021-09-13T18:22:21Z

@blueorangutan package

blueorangutan · 2021-09-13T18:24:02Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-13T19:09:19Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1224

weizhouapache · 2021-09-13T19:16:50Z

@blueorangutan test centos7 xenserver-71 keepEnv

blueorangutan · 2021-09-13T19:18:02Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

weizhouapache · 2021-09-14T06:37:56Z

@blueorangutan test centos7 xenserver-71 keepEnv

blueorangutan · 2021-09-14T06:40:03Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

blueorangutan · 2021-09-14T21:12:39Z

Trillian test result (tid-2031)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50918 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2031-xenserver-71.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Test File
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	test_vpc_vpn.py

svenvogel · 2021-09-16T08:49:00Z

@weizhouapache only for interest because we are using OVS/VLAN at the moment with KVM. What are the fixes in detail? 😄 thanks and cheers

(1) VR <-> VM should work (2) Private GW should work

ovs bridges are deleted by xenserver/ovs automatically ``` [root@ref-trl-1797-x-M7-wei-zhou-xs2 ~]# grep -r xapi7 /var/log/ |grep del-br /var/log/xensource.log:Sep 15 07:13:44 ref-trl-1797-x-M7-wei-zhou-xs2 xcp-networkd: [ info|localhost|611 |org.xen.xapi.xenops.classic events D:4a3d931cd89f|network_utils] /usr/bin/ovs-vsctl --timeout=20 -- --if-exists del-br xapi7 /var/log/daemon.log:Sep 15 07:13:45 ref-trl-1797-x-M7-wei-zhou-xs2 ovs-vsctl: ovs|00001|vsctl|INFO|Called as /usr/bin/ovs-vsctl --timeout=20 -- --if-exists del-br xapi7 ``` which results that xe network exists but bridge does not exist, and operation stuck for 20 minutes at ``` 2021-09-15 16:06:56 DEBUG [root] #### VMOPS enter create_tunnel #### 2021-09-15 16:06:56 DEBUG [root] Creating tunnel from host 2 to host 1 with GRE key 2116 2021-09-15 16:06:56 DEBUG [root] Executing:['/usr/bin/ovs-vsctl', '--timeout=0', 'wait-until', 'bridge', 'xapi7', '--', 'get', 'bridge', 'xapi7', 'name'] 2021-09-15 16:26:56 DEBUG [root] bridge xapi7 for creating tunnel - VERIFIED 2021-09-15 16:26:56 DEBUG [root] Executing:['/usr/bin/ovs-vsctl', 'add-port', 'xapi7', 't2116-2-1', '--', 'set', 'interface', 't2116-2-1', 'type=gre', 'options:key=2116', 'options:remote_ip=10.0.34.230'] ```

weizhouapache · 2021-09-17T13:34:34Z

@weizhouapache only for interest because we are using OVS/VLAN at the moment with KVM. What are the fixes in detail? thanks and cheers

@svenvogel
this PR fixes some issues with Openvswitch/GRE support on kvm and xenserver.
You can find the description of issues in each commit.

OVS/VLAN is not impacted.

weizhouapache · 2021-09-17T13:34:42Z

@blueorangutan package

blueorangutan · 2021-09-17T13:35:03Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-17T13:59:56Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1307

weizhouapache · 2021-09-17T15:02:52Z

@blueorangutan test

weizhouapache · 2021-09-17T15:04:01Z

@blueorangutan test centos7 xenserver-71

blueorangutan · 2021-09-17T15:04:03Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-09-18T02:19:27Z

Trillian test result (tid-2114)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38606 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2114-kvm-centos7.zip
Smoke tests completed. 89 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	75.02	test_kubernetes_clusters.py

yadvr · 2021-09-21T07:31:44Z

@weizhouapache is this critical for 4.16, and is this ready for review - how are we testing it?

…es on xenserver

weizhouapache · 2021-09-27T06:41:23Z

@blueorangutan package

blueorangutan · 2021-09-27T06:42:03Z

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-27T07:19:34Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1401

weizhouapache · 2021-09-27T07:35:23Z

@blueorangutan test

blueorangutan · 2021-09-27T07:36:02Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-09-27T17:24:59Z

Trillian test result (tid-2212)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34079 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2212-kvm-centos7.zip
Smoke tests completed. 90 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2021-09-28T08:57:26Z

@sureshanaparti did you ping the interested parties for testing? Or do you have any advise on testing?

weizhouapache · 2021-09-28T09:30:28Z

@sureshanaparti did you ping the interested parties for testing? Or do you have any advise on testing?

@sureshanaparti @DaanHoogland @nvazquez
I think nobody is using this setting now (advanced zone with GRE isolation) as the feature was broken in some previous versions.

My opinion is
(1) if anyone want to test it, it is fine. ping me if you need help.
(2) if nobody have chance testing it, I think we can merge it if we make sure it does not break existing functionalities (by code review, smoke test, manual test, etc).

I have tested the feature manually,
the new smoke test (test/integration/smoke/test_privategw_acl_ovs_gre.py) passed on kvm and xenserver. component test test_vpc_distributed_routing_offering.py passed on xenserver, but not on kvm as the feature is never implemented on kvm.

if someone find bugs in their testing, we can fix them in next minor releases (4.16 will be LTS as far as I know)

nvazquez

Edit: Still testing on OVS-KVM environment

Manually updated database to set GRE isolation on the existing physical network and added and enabled the Ovs provider.

weizhouapache · 2021-09-29T14:00:19Z

@blueorangutan package

nvazquez · 2021-09-29T16:53:23Z

@blueorangutan package

blueorangutan · 2021-09-29T16:56:02Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-09-29T17:44:28Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1447

blueorangutan · 2021-09-29T17:45:01Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1448

yadvr · 2021-09-30T04:53:30Z

@blueorangutan test

blueorangutan · 2021-09-30T04:54:02Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-09-30T14:31:09Z

Trillian test result (tid-2251)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33248 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5446-t2251-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

svenvogel added component:advanced-networking type:bug labels Sep 16, 2021

OVS/GRE: fix failed to fetch cloudbr* info on host

9fa8f43

weizhouapache force-pushed the 4.16-ovs-issues branch from 2a6ee4a to 7cd5bae Compare September 17, 2021 13:20

weizhouapache added 3 commits September 17, 2021 15:27

OVS/GRE: move ovstunnel.py to python3

ae9c74a

OVS: add test_privategw_acl_ovs_gre.py for automatic testing

0e9a7dc

(1) VR <-> VM should work (2) Private GW should work

weizhouapache force-pushed the 4.16-ovs-issues branch from 7cd5bae to 05ddc19 Compare September 17, 2021 13:27

yadvr modified the milestones: 4.17.0.0, 4.16.0.0 Sep 21, 2021

OVS/GRE: component test test_vpc_distributed_routing_offering.py pass…

ffb510b

…es on xenserver

sureshanaparti added the status:needs-testing label Sep 28, 2021

weizhouapache requested review from nvazquez and sureshanaparti September 28, 2021 09:30

nvazquez self-assigned this Sep 28, 2021

nvazquez approved these changes Sep 28, 2021

View reviewed changes

apache deleted a comment from blueorangutan Sep 29, 2021

OVS/GRE: VPC with distributed routing on kvm (still not working)

2cc47d5

weizhouapache closed this Sep 29, 2021

weizhouapache reopened this Sep 29, 2021

nvazquez assigned borisstoyanov and unassigned nvazquez Sep 30, 2021

yadvr approved these changes Oct 3, 2021

View reviewed changes

yadvr merged commit 09fce75 into apache:main Oct 3, 2021

DaanHoogland removed the status:needs-testing label Jan 28, 2026

Conversation

weizhouapache commented Sep 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Sep 13, 2021

Uh oh!

blueorangutan commented Sep 13, 2021

Uh oh!

blueorangutan commented Sep 13, 2021

Uh oh!

weizhouapache commented Sep 13, 2021

Uh oh!

blueorangutan commented Sep 13, 2021

Uh oh!

weizhouapache commented Sep 14, 2021

Uh oh!

blueorangutan commented Sep 14, 2021

Uh oh!

blueorangutan commented Sep 14, 2021

Uh oh!

svenvogel commented Sep 16, 2021

Uh oh!

weizhouapache commented Sep 17, 2021

Uh oh!

weizhouapache commented Sep 17, 2021

Uh oh!

blueorangutan commented Sep 17, 2021

Uh oh!

blueorangutan commented Sep 17, 2021

Uh oh!

weizhouapache commented Sep 17, 2021

Uh oh!

weizhouapache commented Sep 17, 2021

Uh oh!

blueorangutan commented Sep 17, 2021

Uh oh!

blueorangutan commented Sep 18, 2021

Uh oh!

yadvr commented Sep 21, 2021

Uh oh!

weizhouapache commented Sep 27, 2021

Uh oh!

blueorangutan commented Sep 27, 2021

Uh oh!

blueorangutan commented Sep 27, 2021

Uh oh!

weizhouapache commented Sep 27, 2021

Uh oh!

blueorangutan commented Sep 27, 2021

Uh oh!

blueorangutan commented Sep 27, 2021

Uh oh!

DaanHoogland commented Sep 28, 2021

Uh oh!

weizhouapache commented Sep 28, 2021

Uh oh!

nvazquez left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Sep 29, 2021

Uh oh!

nvazquez commented Sep 29, 2021

Uh oh!

blueorangutan commented Sep 29, 2021

Uh oh!

blueorangutan commented Sep 29, 2021

Uh oh!

blueorangutan commented Sep 29, 2021

Uh oh!

yadvr commented Sep 30, 2021

Uh oh!

blueorangutan commented Sep 30, 2021

weizhouapache commented Sep 13, 2021 •

edited

Loading

nvazquez left a comment •

edited

Loading